Skip to content

added missing CLDR skeleton patterns#7515

Draft
psg-19 wants to merge 2 commits intounicode-org:mainfrom
psg-19:new_skeletons
Draft

added missing CLDR skeleton patterns#7515
psg-19 wants to merge 2 commits intounicode-org:mainfrom
psg-19:new_skeletons

Conversation

@psg-19
Copy link
Copy Markdown
Contributor

@psg-19 psg-19 commented Jan 28, 2026

Fixes #7428
Summary :- added new datetime skeletons patterns to SUPPORTED_STRING_SKELETONS.

Copy link
Copy Markdown
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't utilize these patterns. It just adds some metadata for them.

Copy link
Copy Markdown
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@psg-19
Copy link
Copy Markdown
Contributor Author

psg-19 commented Jan 29, 2026

This doesn't utilize these patterns. It just adds some metadata for them.

yes I guess what I did just adds some test coverage, not actual utilization 😅

@robertbastian robertbastian removed their request for review February 5, 2026 16:56
@robertbastian robertbastian added the waiting-on-author PRs waiting for action from the author for >7 days label Feb 12, 2026
@robertbastian robertbastian marked this pull request as draft February 16, 2026 11:52
@robertbastian
Copy link
Copy Markdown
Member

un-draft once CI is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-author PRs waiting for action from the author for >7 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Hv, EH, and other new skeletons in datagen

3 participants